Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop → 1.59.0 (unknown) #313

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Dec 12, 2023

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.58.0 → ~> 1.59.0) · Repo · Changelog

Release Notes

1.59.0

New features

  • #12518: Add new Lint/ItWithoutArgumentsInBlock cop. (@koic)

Bug fixes

  • #12434: Fix a false positive for Lint/LiteralAssignmentInCondition when using interpolated string or xstring literals. (@koic)
  • #12435: Fix a false positive for Lint/SelfAssignment when using attribute assignment with method call with arguments. (@koic)
  • #12444: Fix false positive for Style/HashEachMethods when receiver literal is not a hash literal. (@koic)
  • #12524: Fix a false positive for Style/MethodCallWithArgsParentheses when EnforcedStyle: omit_parentheses and parens in when clause is used to pass an argument. (@koic)
  • #12505: Fix a false positive for Style/RedundantParentheses when using parenthesized lambda or proc with do...end block. (@koic)
  • #12442: Fix an incorrect autocorrect for Style/CombinableLoops when looping over the same data as previous loop in do...end and {...} blocks. (@koic)
  • #12432: Fix a false positive for Lint/LiteralAssignmentInCondition when using parallel assignment with splat operator in block of guard condition. (@koic)
  • #12441: Fix false positives for Style/HashEachMethods when using destructed block arguments. (@koic)
  • #12436: Fix false positives for Style/RedundantParentheses when a part of range is a parenthesized condition. (@koic)
  • #12429: Fix incorrect autocorrect for Style/MapToHash when using dot method calls for to_h. (@koic)
  • #12488: Make Lint/HashCompareByIdentity aware of safe navigation operator. (@koic)
  • #12489: Make Lint/NextWithoutAccumulator aware of safe navigation operator. (@koic)
  • #12490: Make Lint/NumberConversion aware of safe navigation operator. (@koic)
  • #12491: Make Lint/RedundantWithIndex aware of safe navigation operator. (@koic)
  • #12492: Make Lint/RedundantWithObject aware of safe navigation operator. (@koic)
  • #12493: Make Lint/UnmodifiedReduceAccumulator aware of safe navigation operator. (@koic)
  • #12473: Make Style/ClassCheck aware of safe navigation operator. (@koic)
  • #12445: Make Style/CollectionCompact aware of safe navigation operator. (@koic)
  • #12474: Make Style/ConcatArrayLiterals aware of safe navigation operator. (@koic)
  • #12476: Make Style/DateTime aware of safe navigation operator. (@koic)
  • #12479: Make Style/EachWithObject aware of safe navigation operator. (@koic)
  • #12446: Make Style/HashExcept aware of safe navigation operator. (@koic)
  • #12447: Make Style/MapCompactWithConditionalBlock aware of safe navigation operator. (@koic)
  • #12484: Make Style/Next aware of safe navigation operator. (@koic)
  • #12486: Make Style/RedundantArgument aware of safe navigation operator. (@koic)
  • #12454: Make Style/RedundantFetchBlock aware of safe navigation operator. (@koic)
  • #12495: Make Layout/RedundantLineBreak aware of safe navigation operator. (@koic)
  • #12455: Make Style/RedundantSortBy aware of safe navigation operator. (@koic)
  • #12456: Make Style/RedundantSortBy aware of safe navigation operator. (@koic)
  • #12480: Make Style/ExactRegexpMatch aware of safe navigation operator. (@koic)
  • #12457: Make Style/Sample aware of safe navigation operator. (@koic)
  • #12458: Make Style/SelectByRegexp cops aware of safe navigation operator. (@koic)
  • #12494: Make Layout/SingleLineBlockChain aware of safe navigation operator. (@koic)
  • #12461: Make Style/StringChars aware of safe navigation operator. (@koic)
  • #12468: Make Style/Strip aware of safe navigation operator. (@koic)
  • #12469: Make Style/UnpackFirst aware of safe navigation operator. (@koic)

Changes

  • #12522: Make Style/MethodCallWithoutArgsParentheses allow the parenthesized it method in a block. (@koic)
  • #12523: Make Style/RedundantSelf allow the self.it method in a block. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 60 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Dec 12, 2023
@cmur2 cmur2 merged commit 1ae0642 into master Dec 12, 2023
6 checks passed
@cmur2 cmur2 deleted the depfu-update-rubocop-1.59.0 branch December 12, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant