Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manylinux wheels not building (issue #265) #268

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

Crozzers
Copy link
Contributor

No description provided.

@dhdaines
Copy link
Contributor

Thank you!

@dhdaines dhdaines merged commit 16fe6eb into cmusphinx:master Jul 11, 2022
@dhdaines
Copy link
Contributor

actually the wheels still don't quite build right, I am fixing now...

@dhdaines
Copy link
Contributor

There is no SWIG in the manylinux1 wheels, so I had to switch to manylinux2014 for all Python versions in build_wheels.sh.

SWIG is probably going to be removed shortly anyway because as far as I can tell nobody actually uses its bindings for Ruby, it's a dependency that annoys a lot of people, and it's more difficult to produce a properly Pythonic API in it. I'll pull in the bindings from https://github.com/ReadAlongs/SoundSwallower and just ensure they remain compatible, probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants