Do not attempt to align phones to impossibly short durations (fixes #339) #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we explcitly disable
bestpathin the command-line for phone and state alignment due to its tendency to put fake</s>with a duration of a single frame at the end of the utterance, this was not the case in the Python API, either because I forgot, but most likely for Reasons (some people apparently usebestpathwith FSG search or alignment, don't ask me why).This is a more robust fix, which will simply refuse to force-align something to an impossible duration. We may also wish to fix the upstream problem of the fake
</s>but that is more complex to do. This at least prevents crashing!