-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files longer than 24 hours are not handled correctly #10
Comments
Hi @dm413 and thanks for your contribution! |
Added two tests, one for GetMetadataAsync and one for Progress events. I'm not experienced with xunit tests; let me know if there are problems. One issue was creating a file with > 24 hours duration to test with. I didn't want to put a large (175 MB) file into the repo, so the test program creates the test file at run time, by copying the SampleAudio file many times until the file is about 31 hours long . This means the first time you run the test it takes 10 to 20 seconds to create the test audio file. |
Thank you! |
thanks again @dm413! |
I am processing audio files that are 6 days long. When I call
GetMetaDataAsync
, the duration is returned as zero. Also I do not getProgress
events after 24 hours of audio have been processed.This happens because the code uses
TimeSpan.TryParse
to parse the duration string that is output by ffmpeg.TimeSpan.TryParse
does not handle hours that are greater than 23 (it expects days). Ffmpeg however produces a duration inh:mm:ss.fff
format where the hours field can grow as large as necessary.The text was updated successfully, but these errors were encountered: