-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removes source file includes in ccnl-utils #270
Conversation
For the sake of transparency - I've missed to split ccnl-ext-hmac.c into ccnl-ext-hmac.{h,c}. This would require to remove the |
Okay. I've seperated the source into a header and source of ccnl-ext-hmac.c and lib-sha256.c - There should be no issue with empty translation units. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Minor point: add documentation to hmac? would this be useful?
Will do and update the PR |
I've tried my best, but there are some gaps to fill. Particularly, the |
Contribution description
This PR restructures the
ccnl-utils
module and introduces ainclude
andsrc
directory. The C-file includes have been split into a header and source file. Hence, all occurrences of e.g.have been replaced by
These changes also required some customizations in the
CMakeLists.txt
file of the module. It also removes the USE_SIGNATURES use flag since ISO C forbids empty translation units (which was a result of splitting ccnl-crypto.c into ccnl-crypto.{h,c})Issues/PRs references
Fixes #236