Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spec compliance] Validate installation names correctly #126

Open
jlegrone opened this issue Sep 17, 2019 · 0 comments
Open

[spec compliance] Validate installation names correctly #126

jlegrone opened this issue Sep 17, 2019 · 0 comments
Labels
spec Support new spec changes or fix gaps with the spec
Milestone
cnab-go 1.0

Comments

@jlegrone
Copy link
Member

The spec says

Installation names MUST consist of Graph Unicode characters and MAY be user-readable. The Unicode Graphic characters include letters, marks, numbers, punctuation, symbols, and spaces, from categories L, M, N, P, S, Zs.

The current test cases do not quite line up with this:

https://github.com/deislabs/cnab-go/blob/fae945b60a78d539434da178ae5c8e212f2977da/claim/claim_test.go#L49-L60

As noted in https://github.com/deislabs/cnab-go/pull/119/files#r324850692
@jlegrone jlegrone added this to the cnab-go 1.0 milestone Sep 17, 2019
@jlegrone jlegrone mentioned this issue Sep 17, 2019
Merged
@carolynvs carolynvs added the spec Support new spec changes or fix gaps with the spec label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec Support new spec changes or fix gaps with the spec
Projects
None yet
Milestone
cnab-go 1.0
Development

No branches or pull requests
2 participants
@carolynvs @jlegrone