Allow installation names including "." character #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyn
approved these changes
Sep 5, 2019
| for name, expect := range map[string]bool{ | ||
| "M4cb3th": true, | ||
| "Lady MacBeth": false, //spaces illegal | ||
| "Lady MacBeth": false, // spaces illegal | ||
| "3_Witches": true, | ||
| "Banquø": false, // We could probably loosen this one up |
There was a problem hiding this comment.
Unrelated to this PR, but ø is part of L and here it isn't approved. Group S is spacing and is also approved. In fact, the only group that seems to not be allowed here is C so none of the tests here should fail. Am I missing something?
There was a problem hiding this comment.
On that note, my understanding is that, if you are using regex (and thus re2) you can get away using unicode character classes explicitly and probably get away with [\pL\pM\pN\pP\pS\pZ]* or so...
There was a problem hiding this comment.
I'll open a new issue for this, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the docs:
This PR doesn't quite bring cnab-go up to spec, but does enable the use of installation names which include the
.character (this supports our internal installation naming convention). If someone would like to school me in regex we can update this PR to be fully spec compliant. 😄