-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duffle driver ignores operation writer, writes directly to stdout #78
Comments
Seems reasonable to me. |
Is this still the case? If so, can you give a pointer? |
Yup, it's still the case. 😀 You feel like tackling it? The driver implements the common interface for a driver, but in it's |
When discussing this issue with @benpatt, I wondered if there was a distinction between the output stream for the logs from the docker driver and from the container that the docker drive runs. @carolynvs would you say that all the logs from the driver itself and from the container should be sent to the same output stream (the one in the |
The driver doesn't seem to print much (just 1 error message about pulling the image). Outputting everything to the Operation writer would be just fine by me. |
As said on this PR review cnabio/duffle#808 (review)
|
It would be good to add a driver test to tie down the behaviour. Otherwise, it is bound to break docker/app in future.
Good catch. Raised cnabio/duffle#809 to delete the old code. We also need to move this issue to cnab-go which is now its proper home. |
The docker driver is passed on the
Operation
struct a writer for any output, but instead it is writing directly to stdout.As part of Porter we are implementing a verbose flag and would like to be able to show/hide this output, but it is printing directly so we can't control it. Would you be up for a pull request that switches the driver over to using
op.Out
?The text was updated successfully, but these errors were encountered: