Write docker output to op writer #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of writing by default to os.Stdout, the docker driver writes to op.Out and the new field op.Err. The op defaults those values to stdout/stderr, so if you weren't setting them previously the behavior is the same. But for tools like porter that were collecting the output, this enables them to capture all the output and not have rogue lines printed directly to the screen. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
docker-driver-output
branch
from
bf388c0
to
1bc688d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of writing by default to os.Stdout, the docker driver writes to op.Out and the new field op.Err. The op defaults those values to stdout/stderr, so if you weren't setting them previously the behavior is the same though errors are now sent to stderr instead of all lumped into stdout. But for tools like porter that were collecting the output, this enables them to capture all the output and not have rogue lines printed directly to the screen.
This doesn't remove containerOut/containerErr which Docker is relying upon. It should just change the defaults so that the op writers are used first, and are overridden only when SetContainerOut/Err are used.
Closes #78