Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last dependency on deislabs/cnab-go #168

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

silvin-lubecki
Copy link
Contributor

A last piece of dependency remained in the go.mod file, making downstream projects still depend on github.com/deislabs/cnab-go.
I also used this PR to run go mod tidy and clean all unused dependencies. Only one was not removed successfully github.com/Azure/go-autorest, so I had to re-add it manually.

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
- Refreshing some dependencies
- Also removing all unused dependencies
- Had to re-add manually github.com/Azure/go-autorest dependency in go.mod

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for thoroughly going through the remaining places where deislabs was used!

LGTM

@silvin-lubecki silvin-lubecki merged commit 8b2ff3a into cnabio:master Dec 27, 2019
@silvin-lubecki silvin-lubecki deleted the fix-imports branch December 27, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants