Pass context to drivers during bundle operation #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we execute a bundle operation, pass a context so that they can handle cancellations and timeouts. Signed-off-by: Carolyn Van Slyck <carolyn.vanslyck@microsoft.com>
carolynvs
commented
Jun 16, 2020
| @@ -78,7 +79,7 @@ func (a Action) Run(c claim.Claim, creds credentials.Set, opCfgs ...OperationCon | |||
| } | |||
|
|
|||
| var opErr *multierror.Error | |||
| opResult, err := a.Driver.Run(op) | |||
| opResult, err := a.Driver.Run(context.TODO(), op) | |||
There was a problem hiding this comment.
I'm still working on how we want to introduce the context, leaning towards the first parameter to Action.Run unless there's a reason for opCfgs to be involved somehow?
There was a problem hiding this comment.
Making context the first parameter is probably most idiomatic. From the package docs:
Do not store Contexts inside a struct type; instead, pass a Context explicitly to each function that needs it. The Context should be the first parameter, typically named ctx
jlegrone
reviewed
Jun 17, 2020
| @@ -32,7 +33,7 @@ type mockDriver struct { | |||
| func (d *mockDriver) Handles(imageType string) bool { | |||
| return d.shouldHandle | |||
| } | |||
| func (d *mockDriver) Run(op *driver.Operation) (driver.OperationResult, error) { | |||
| func (d *mockDriver) Run(context context.Context, op *driver.Operation) (driver.OperationResult, error) { | |||
There was a problem hiding this comment.
To avoid shadowing the package name
Suggested change
| func (d *mockDriver) Run(context context.Context, op *driver.Operation) (driver.OperationResult, error) { | |
| func (d *mockDriver) Run(ctx context.Context, op *driver.Operation) (driver.OperationResult, error) { |
|
Closing because this is really out of date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we execute a bundle operation, pass a context so that they can handle cancellations and timeouts.
The kubernetes driver required enough changes that I created #220 to track updating it to actually use cxt.
TODO: