Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schemaVersion to credentialSet #229

Merged
merged 3 commits into from
Sep 30, 2020

Commits on Aug 17, 2020

  1. Add schemaVersion to credentialSet

    Add a schemaVersion field to credentialSet so that we can identify the
    spec version that the credential set adheres to. This was very useful
    for claims, we use it for data migrations when the claim spec changes,
    and it is best to have it _before_ we need to change the spec. Worst
    case we never change the spec and we all win.
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    992301d View commit details
    Browse the repository at this point in the history
  2. Fix comment

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    a4a6a5b View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Add constructor for CredentialSet

    * Ensure that SchemaVersion is set on new CredentialSets.
    * Try a new pattern for the default schema that doesn't involve checking
    for errors parsing the spec constant. We test the spec constant in our
    tests and people can rely on us having set it properly.
    
    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    carolynvs committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    d6bf372 View commit details
    Browse the repository at this point in the history