Fix unmarshal for claim results #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally we were defining output metadata as a map[string]interface{},
and then just casting as needed any output metadata values to
map[string]string. This worked fine when setting and then immediately
checking values, because we set the metadata correctly to begin with.
When a result is unmarshaled though, the json decoder is unmarshaling
the output metadata values as map[string]interface{} and this prevented
the helper methods for reading the metadata from working.
I've updated the OutputMetadata type to be map[string]map[string]string
so that we aren't relying on casts working, and to give the json decoder
the hint it needs to initialize the types correctly.
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
retrieve-output-metadata
branch
from
071e46e
to
71ac698
Compare
vdice
approved these changes
May 3, 2022
carolynvs
added a commit
to carolynvs/porter
that referenced
this pull request
May 4, 2022
Pin to cnab-go v0.23.2 with a fix for reading output metadata from a claim result after it has been unmarshaled from json. cnabio/cnab-go#283 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally we were defining output metadata as a map[string]interface{}, and then just casting as needed any output metadata values to map[string]string. This worked fine when setting and then immediately checking values, because we set the metadata correctly to begin with.
When a result is unmarshaled though, the json decoder is unmarshaling the output metadata values as map[string]interface{} and this prevented the helper methods for reading the metadata from working.
I've updated the OutputMetadata type to be map[string]map[string]string so that we aren't relying on casts working, and to give the json decoder the hint it needs to initialize the types correctly.