Fix installation of golangci-lint #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However we were installing golangci-lint before (using their special install script) doesn't work on our CI anymore, or my local machine. I've updated to the most recent version of golangci-lint so that I could test it locally on my arm64 machine, and switch to using go install to install the tool. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
* Run go fmt over project * Do not use testing.T helper from an anonymous function Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
We were using go get to install tools during make bootstrap. The way to install go packages into GOPATH/bin is now go install. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
vdice
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However we were installing golangci-lint before (using their special install script) doesn't work on our CI anymore, or my local machine. I've updated to the most recent version of golangci-lint so that I could test it locally on my arm64 machine, and switch to using go install to install the tool.
I've also updated the code quick to get the
make linttarget passing again: