Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export "BuildDockerClientOptions" #293

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

ulyssessouza
Copy link
Contributor

This enables the configuration of already instanciated DockerCli

@ulyssessouza ulyssessouza marked this pull request as ready for review September 7, 2022 13:21
Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update any other places in the code where this is referenced? Looks like the unit tests are failing because client_test.go uses that function too.

https://dev.azure.com/deislabs/cnab-go/_build/results?buildId=7250&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=5caf77c8-9b10-50ef-b5c7-ca89c63e1c86

This enables the configuration of already instanciated DockerCli

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
@ulyssessouza
Copy link
Contributor Author

@carolynvs Thanks for the review. I've just changed the tests too...

Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@carolynvs carolynvs merged commit 1ca5c87 into cnabio:main Sep 7, 2022
@carolynvs
Copy link
Contributor

I just tagged your change with v0.24.1 so that you can use an official release in your go.mod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants