Add bundle.json file to invocation image #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyn
suggested changes
Jun 13, 2019
glyn
reviewed
Jun 13, 2019
100-CNAB.md
Outdated
| @@ -93,7 +93,6 @@ The process for standardization is described in an appendix: | |||
| ## History | |||
|
|
|||
| - The `bundle.cnab` is now the name of a signed `bundle.json`. | |||
| - The `bundle.json` is now a stand-alone artifact, not part of the invocation image. | |||
There was a problem hiding this comment.
Rather than rewrite history, I think it would be better to add a new history line. Also, I'm not sure what the deleted line was referring to - perhaps bundle.json used to be literally part of the invocation image?
There was a problem hiding this comment.
@glyn not sure if my added line made it less confusing. Let me know your thoughts or suggestions.
There was a problem hiding this comment.
The line was fine, but in the wrong place. ;-)
|
@youreddy did you intend to close this? |
|
@jeremyrickard, I think I did by accident. And lost my commits along the way! Will recover and reopen the pr later today. |
- Addresses issue #144
glyn
approved these changes
Jun 17, 2019
Co-Authored-By: Glyn Normington <gnormington@pivotal.io>
Co-Authored-By: Glyn Normington <gnormington@pivotal.io>
youreddy
requested review from
simonferquel,
michelleN,
radu-matei and
technosophos
|
Added all @glyn's suggestions above. Ready for review! |
jeremyrickard
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundle.jsonas a file at/var/run/cnab/bundle.json#144/cnab/bundle.json. I didn't feel a strong need to throw it into a subdirectory inside ofcnabbut I'm happy to update the PR if people would rather have the bundle definition at a different location./cc @glyn @radu-matei