-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bundle.json file to invocation image #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is one mistake which needs correcting and I've suggested some image vs container clarifications which I don't feel strongly about.
(Please note this review should be regarded as non-binding since I am not a spec maintainer.)
100-CNAB.md
Outdated
@@ -93,7 +93,6 @@ The process for standardization is described in an appendix: | |||
## History | |||
|
|||
- The `bundle.cnab` is now the name of a signed `bundle.json`. | |||
- The `bundle.json` is now a stand-alone artifact, not part of the invocation image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than rewrite history, I think it would be better to add a new history line. Also, I'm not sure what the deleted line was referring to - perhaps bundle.json
used to be literally part of the invocation image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glyn not sure if my added line made it less confusing. Let me know your thoughts or suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line was fine, but in the wrong place. ;-)
@youreddy did you intend to close this? |
@jeremyrickard, I think I did by accident. And lost my commits along the way! Will recover and reopen the pr later today. |
- Addresses issue #144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the history is out of order - please see my suggestion.
Co-Authored-By: Glyn Normington <gnormington@pivotal.io>
Co-Authored-By: Glyn Normington <gnormington@pivotal.io>
Added all @glyn's suggestions above. Ready for review! |
bundle.json
as a file at/var/run/cnab/bundle.json
#144/cnab/bundle.json
. I didn't feel a strong need to throw it into a subdirectory inside ofcnab
but I'm happy to update the PR if people would rather have the bundle definition at a different location./cc @glyn @radu-matei