Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cnab-go to v0.10.0-beta1 #102

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Conversation

carolynvs
Copy link
Collaborator

Bundle.SchemaVersion was changed to a custom type, based on a string.

Bundle.SchemaVersion was changed to a custom type, based on a string.

Signed-off-by: Carolyn Van Slyck <carolyn.vanslyck@microsoft.com>
@carolynvs
Copy link
Collaborator Author

carolynvs commented Apr 7, 2020

I can't reproduce this test failure. Could it be a flake perhaps? When I ran it locally, it passed at first (which is why I submitted the PR), then when I saw this build failure I tried again and I got a different error, and now it's passing for me again. 😀

@silvin-lubecki
Copy link
Collaborator

Yes this test is flaky, @radu-matei reported it here #98. I re-ran the tests and everything is green now 👍

Copy link
Collaborator

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 00159a9 into cnabio:master Apr 9, 2020
@carolynvs carolynvs deleted the bump-cnabgo branch March 15, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants