Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remotes: remove reference to pkg/errors #124

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Mar 22, 2022

when containderd is upgraded, tests started to break due to the changes in containerd's error handling.
This PR switches error handling from "github.com/pkg/errors" to go native "errors" package

Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
@carolynvs carolynvs self-requested a review March 22, 2022 17:11
Copy link
Collaborator

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I checked and this fixes the error in our Porter smoke tests that showed up after bumping our cnab-to-oci reference. 👍

@carolynvs carolynvs merged commit ce9f377 into cnabio:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants