Skip duplicate image layers when copying #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some images have duplicate layers, for example docker/whalesay. This can be caused by DOCKERFILE commands that are executed but do not modify the filesystem. While it's not optimal for an image to do this, it shouldn't cause errors either. When we copy the images used by a manifest into the bundle repository, we are creating a copy task for each layer resulting in multiple copy tasks attempting to copy the same layer. Only the first copy task works, and the others fail with "unexpected size" errors because the layer was already copied (fully or in part) in the previous task. I've updated descriptorContentHandler to keep track of the layers, so that we can skip over duplicate layers. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some images have duplicate layers, for example docker/whalesay. This can be caused by DOCKERFILE commands that are executed but do not modify the filesystem. While it's not optimal for an image to do this, it shouldn't cause errors either.
When we copy the images used by a manifest into the bundle repository, we are creating a copy task for each layer resulting in multiple copy tasks attempting to copy the same layer. Only the first copy task works, and the others fail with "unexpected size" errors because the layer was already copied (fully or in part) in the previous task.
I've updated descriptorContentHandler to keep track of the layers, so that we can skip over duplicate layers.
Fixes #128