Use same canonical json library as cnab-go #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
canonical-json-switcheroo
branch
from
d921552
to
7f40404
Compare
carolynvs
force-pushed
the
canonical-json-switcheroo
branch
from
7f40404
to
073c36c
Compare
The cnab-go library that we use to work with bundles switched to a canonical json library with support for numeric types a while back and I forgot to update cnab-to-oci at the same time. This updates cnab-to-oci to use the same library, github.com/cyberphone/json-canonicalization, and when possible just use the helper methods defined on cnab-go's Bundle type instead of doing the marshaling ourselves. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
canonical-json-switcheroo
branch
from
073c36c
to
b017a60
Compare
radu-matei
reviewed
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cnab-go library that we use to work with bundles switched to a canonical json library with support for numeric types a while back and I forgot to update cnab-to-oci at the same time.
This updates cnab-to-oci to use the same library, github.com/cyberphone/json-canonicalization, and when possible just use the helper methods defined on cnab-go's Bundle type instead of doing the marshaling ourselves.
Fixes #131