Replace deislabs/duffle dependency with deislabs/cnab-go #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove pulled test bundle
|
Updated to point to |
|
See cnabio/duffle#681 on how this is used in Duffle. |
silvin-lubecki
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
LGTM, thank you @radu-matei 👍
I guess the +35k -9K (I would have assume the opposite, as you removed almost all the duffle dependency) is due to the bump of docker/docker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revision used for
cnab-gois coming from this PR - cnabio/cnab-go#2