Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a layer for the bundle config manifest #64

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Aug 20, 2019

This layer is needed for hub to be able to show the image tag and not
only the invocation image tag.

This layer is needed for hub to be able to show the image tag and not
noly the invocation image tag.
@rumpl rumpl force-pushed the config-layer branch 3 times, most recently from 792f9fa to 2d31d0d Compare August 21, 2019 09:41
remotes/mocks_test.go Outdated Show resolved Hide resolved
converter/types.go Show resolved Hide resolved
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Copy link
Collaborator

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @rumpl 👍

Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit cfadbfd into cnabio:master Aug 21, 2019
Copy link
Contributor

@jcsirot jcsirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants