Complete minimal bundle.json that needs no fixup #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishankatdatadog
force-pushed
the
trishankatdatadog/fix-bundle-json
branch
from
4553a00
to
e545bd7
Compare
|
Hmm, looks like that bundle is deliberately designed to need a fixup! Will add a separate file. |
|
Would it make sense to add a note in the doc as to how the files should be used? |
|
Sure! Do you mean the README? Where specifically do you think would be best? |
|
@trishankatdatadog can you rebase your PR 🙏 ? |
|
@silvin-lubecki Is this ok now? |
Signed-off-by: Trishank K Kuppusamy <trishank.kuppusamy@datadoghq.com>
Signed-off-by: Trishank K Kuppusamy <trishank.kuppusamy@datadoghq.com>
trishankatdatadog
force-pushed
the
trishankatdatadog/fix-bundle-json
branch
from
5c63d4c
to
5b0b683
Compare
|
The build failure is because if #98, I still haven't figured out the reason for it, but it is definitely not introduced by this PR. |
radu-matei
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.