Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go modules #99

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Switch to Go modules #99

merged 1 commit into from
Feb 20, 2020

Conversation

radu-matei
Copy link
Member

@radu-matei radu-matei commented Feb 14, 2020

We should not merge until we have working (and passing) CI.

Edit: it turns out Circle is actually running the builds, but not reporting back to GitHub because maybe it's not authorized - https://circleci.com/gh/cnabio/cnab-to-oci/300

@radu-matei
Copy link
Member Author

radu-matei commented Feb 14, 2020

#98 is being hit here, and this might be better rebased on top of #95.

Copy link
Collaborator

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks a lot @radu-matei for handling that !

@carolynvs
Copy link
Collaborator

I don't have permission in circle to enable this, but I can approve it on the GH side once requested.

https://circleci.com/docs/2.0/enable-checks/

I think that's what needs to happen, want to give it a go @silvin-lubecki ?

@vdice
Copy link
Member

vdice commented Feb 14, 2020

@radu-matei I believe I've enabled the circleci app now; can you try re-triggering with a fresh push?

@silvin-lubecki
Copy link
Collaborator

The build failed 🤔

--- FAIL: TestPromisesScheduleErroredDontBlockDontRun (0.00s)
    promises_test.go:87: assertion failed: expected an error, got nil

@radu-matei
Copy link
Member Author

@silvin-lubecki - and there's another transient error, #98.
We should definitely not merge until we fix them.

Signed-off-by: Radu M <root@radu.sh>
@radu-matei
Copy link
Member Author

Rebased on top of master, which updates the Go version in CI.
This means the build is now passing, and given that #98 also occurs in current master, and so is not introduced by this PR, I think we should merge it and track #98 separately (we already do that).

Thoughts?

@radu-matei radu-matei merged commit b573167 into cnabio:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants