This repository has been archived by the owner on May 3, 2022. It is now read-only.
fix(inspect): remove defaultDomain from pkg/reference #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently looking into a cleaner fix by refactoring pkg/reference, but this gets things working for the time being. |
|
I'm getting this error on install: Am I doing something wrong to test? |
michelleN
reviewed
Nov 20, 2018
pkg/reference/normalize.go
Outdated
| const ( | ||
| // DefaultDomain is the default docker domain. | ||
| // HACK(bacongobbler): set DefaultDomain to something arbitrary that will never be used, and strip it out after calling ParseNormalizedName. | ||
| DefaultDomain = "i.hope.nobody.claims.this.domain" |
bacongobbler
changed the title
|
going back to the drawing board, so I'm marking this as WIP for the time being |
Docker's pkg/reference package relies on the assumption that reference.splitDockerDomain() returns the default domain when it's not present. This triggers a bug with `duffle inspect` and others where `duffle inspect helloworld` will search for a bundle called `hub.cnlabs.io/helloworld:latest`. This commit removes reference.ParseNormalizedReference from appending `defaultDomain` to the bundle name. Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
bacongobbler
changed the title
|
okay, I've removed the concept of a defaultDomain from pkg/reference and all seems to work again. |
radu-matei
reviewed
Nov 22, 2018
| } else { | ||
| domain, remainder = name[:i], name[i+1:] | ||
| } | ||
| return | ||
| } | ||
|
|
||
| // familiarizeName returns a shortened version of the name familiar |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker's pkg/reference package relies on the assumption that reference.splitDockerDomain() returns the default domain when it's not present. This triggers a bug with
duffle inspectand others whereduffle inspect helloworldwill search for a bundle calledhub.cnlabs.io/helloworld:latest. It uses hub.cnlabs.io instead of docker.io because we changed thedefaultDomainfield.This hack strips out the DefaultDomain from the image reference when searching for the bundle in repositories.json.
closes #337
Signed-off-by: Matthew Fisher matt.fisher@microsoft.com