-
Notifications
You must be signed in to change notification settings - Fork 54
ref(duffle): hide http-based workflow commands (pull, push, search) #491
Conversation
Hey @bacongobbler - I see you're removing push/pull/search here. I know we decided that we probably don't want people to get confused at launch with the repo/server side functionality but I hate to lose this work. What do you think about just making those commands hidden? If we add a
|
IMO at this point I believe it's best if the commands were all thrown away and to start from scratch, starting with proper repository client packages and a backend that conforms to the repository API laid out in the CNAB repository specification. The current pull/push/search API does not conform at all to the spec, relying on old assumptions we made during initial proof of concepts, is buggy and (mostly) un-salvagable code. I'm considering shutting off hub.cnlabs.io for the time being (because of the above reasons RE: non-conforming/buggy), so there would be no backend to use anyways. I'm open to the idea if you think there's parts of push/pull/search that should be salvaged, but from my point of view it doesn't look like any of it can be salvaged/refactored. |
okay, I hid the commands from output but retained their existing behaviour. |
Indeed, @bacongobbler , I was going to put up a functional test PR in this repo wherein the default would be to iterate over all remote bundles (via |
Yeah agreed. The "remote bundle" story is in limbo at the moment so I wouldn't invest time writing functional tests on that side, at least not until after KubeCon. Once we sort that story out then I absolutely agree that having some test infrastructure around it would be +💯 |
LGTM - though I think there still may be references to |
Good catch. I originally removed those references from the README but then added them back when I hid those CLI commands. I think it'll just confuse users keeping them in. I'll remove them. :) |
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
While we are still sorting out the server-side part of the specification, we should remove the CLI part of the codebase. This change means that the only way to install a bundle from a URL is through the
duffle install --insecure -f
flag.closes #317
closes #418
closes #426
TODO:
duffle pull
,duffle push
andduffle search
.Signed-off-by: Matthew Fisher matt.fisher@microsoft.com