This repository has been archived by the owner on May 3, 2022. It is now read-only.
feat(keys): implement duffle keys export <PATH> --armored
#510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
bacongobbler
commented
Nov 23, 2018
| newfile := filepath.Join(dirname, "save.gpg") | ||
| is.NoError(kr.SavePublic(newfile, false, true)) | ||
|
|
||
| t.Skip("Go openpgp bug with armored keys? gpg --import seems to work fine.") |
There was a problem hiding this comment.
cc @technosophos (or anyone else that knows openpgp well enough), would you mind helping me figure this odd bug out? It looks like we can export armored keys into the right format, but for some reason it can't be imported back in. Disabling this skip ends in the following error which is similar to helm/helm#2843:
--- FAIL: TestKeyRing_SavePublicArmored (0.00s)
c:\Users\me\code\go\src\github.com\deis\duffle\pkg\signature\keyring_test.go:235:
Error Trace: keyring_test.go:235
Error: Received unexpected error:
openpgp: invalid data: tag byte does not have MSB set
Test: TestKeyRing_SavePublicArmored
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x6a28b1]
goroutine 6 [running]:
testing.tRunner.func1(0xc0000e6100)
C:/ProgramData/Fish/Barrel/go/1.11/go/src/testing/testing.go:792 +0x38e
panic(0x6f4420, 0x99d6b0)
C:/ProgramData/Fish/Barrel/go/1.11/go/src/runtime/panic.go:513 +0x1c7
github.com/deis/duffle/pkg/signature.TestKeyRing_SavePublicArmored(0xc0000e6100)
C:/Users/me/code/go/src/github.com/deis/duffle/pkg/signature/keyring_test.go:236 +0x2d1
testing.tRunner(0xc0000e6100, 0x766840)
C:/ProgramData/Fish/Barrel/go/1.11/go/src/testing/testing.go:827 +0xc6
created by testing.(*T).Run
C:/ProgramData/Fish/Barrel/go/1.11/go/src/testing/testing.go:878 +0x35a
FAIL github.com/deis/duffle/pkg/signature 0.227s
|
Whoops... didn't see #498. Closing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #459
Signed-off-by: Matthew Fisher matt.fisher@microsoft.com