Move to deislabs/cnab-go

[silvin-lubecki]

Vendor and use github.com/deislabs/cnab-go library, which extracted pkg/bundle.

Signed-off-by: Silvin Lubecki silvin.lubecki@docker.com

[silvin-lubecki]

@radu-matei I don't have access to the duffle-CI logs, so I don't know what is failling...

[radu-matei]

@silvin-lubecki -- I was planning this as part of #681, but I don't really see any reason not to have this as a separate PR.

I rescheduled the build, here's why it fails:

golangci-lint run --config ./golangci.yml
cmd/duffle/build.go:21: File is not `goimports`-ed (goimports)
	"github.com/deislabs/cnab-go/bundle"
cmd/duffle/credential_generate.go:16: File is not `goimports`-ed (goimports)
	"github.com/deislabs/cnab-go/bundle"
cmd/duffle/install.go:13: File is not `goimports`-ed (goimports)
	"github.com/deislabs/cnab-go/bundle"
Makefile:74: recipe for target 'lint' failed
make: *** [lint] Error 1
##[error]Bash exited with code '2'.

Thanks!

[silvin-lubecki]

Just rebased and fixed the imports, thank you @radu-matei 👍

[radu-matei]

GitHub seems to be having some troubles today, both CIs are currently pending:

&{Response:0xc000114000 NextPage:0 PrevPage:0 FirstPage:0 LastPage:0 Rate:github.Rate{Limit:6100, Remaining:6059, Reset:github.Timestamp{2019-04-11 17:25:49 +0000 UTC}}}Error: POST https://api.github.com/repos/deislabs/duffle/check-runs: 500  [] (got )

[radu-matei]

Any particular reason why deislabs/cnab-go is not in Gopkg.toml?

[silvin-lubecki]

Well, the gopkg.lock already pin-points the deislabs/cnab-go package, so I guess it won't change unless someone does an explicit update on it, or if the resolver needs bump it because of a transitive dependency.

I think the less you have in the Gopkg.toml the better, and you should only pin-point hard requirements. In an ideal world you even should have nothing in this file, as dep automatically resolves all the dependencies and transitive ones.

That said, I may be wrong and would be happy to add it to the Gopkg.toml file 👍

[radu-matei]

LGTM.
Thanks a lot for your contribution, I'll go ahead and rebase #681 on top of this work.