Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Add inital code coverage and publish test results #713

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

radu-matei
Copy link
Member

@radu-matei radu-matei commented Apr 17, 2019

This publishes the test results and code coverage to Azure Pipelines.

I'm still mildly annoyed that the current Azure Pipelines task ignores a custom code coverage report that we could upload (and not include bogus "classes", or "assemblies"), but it feels like a good start.

Thoughts?

@ghost ghost assigned radu-matei Apr 17, 2019
@ghost ghost added the review label Apr 17, 2019
Kick off CI again

Update display name

Temporarily remove container

Fix coverage

Try gocover-cobertura

Add coverage make target

Fix makefile indentation

Add gocov-xml to make bootstrap

Remove gocov-html as Azure Pipelines auto-generates HTML report
@radu-matei radu-matei marked this pull request as ready for review April 17, 2019 19:53
@@ -77,6 +77,9 @@ HAS_DEP := $(shell $(CHECK) dep)
HAS_GOLANGCI := $(shell $(CHECK) golangci-lint)
HAS_GOIMPORTS := $(shell $(CHECK) goimports)
GOLANGCI_VERSION := v1.16.0
HAS_COCOV_XML := $(shell command -v gocov-xml;)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, this is a typo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmk when it's fixed and u want a review!

@michelleN michelleN added this to In Progress in duffle 0.1.0-ralpha.6+flirtini via automation Apr 23, 2019
@carolynvs carolynvs removed their request for review October 14, 2019 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants