This repository has been archived by the owner on May 3, 2022. It is now read-only.
Improve how relocation mappings are applied #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
reviewed
Sep 16, 2019
cmd/duffle/main_test.go
Outdated
| expectedInvocationImage: "example.com/original", | ||
| expectedOpRelocatorErrorMessage: "", | ||
| }, | ||
| "non-existent relocation mapping file": { |
There was a problem hiding this comment.
What is if the difference between this test case and "bad relocation mapping file"? They both seem to have the same setup with a non-existent relocation mapping file, but then they each have different expectedInvocationImage which I don't quite understand.
There was a problem hiding this comment.
Well spotted! There is no significant difference, so I've deleted one of them. expectedInvocationImage is unused since expectedErrorMessage is non-empty and so its value makes no difference.
There was a problem hiding this comment.
Pushed a fix and also improved the test to check the mounting of the relocation mapping.
Also support a relocation mapping flag on the status command. Fixes cnabio#858 Fixes cnabio#859
glyn
force-pushed
the
use-op-cfg-for-relocation
branch
from
35f1960
to
f912e0b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also support a relocation mapping flag on the status command.
Fixes #858
Fixes #859