Skip to content

Commit

Permalink
address some review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
trishankatdatadog committed Jun 30, 2020
1 parent 15ad935 commit f786da0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 11 deletions.
6 changes: 3 additions & 3 deletions pkg/intoto/metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ import (
// Metadata points to root layout, its public keys, and/or links
type Metadata struct {
Data []byte `json:"data"`
PublicKeys []string `json:"public-keys"` // filenames
Links []string `json:"links"` // filenames
PublicKeys []string `json:"pubkeys"` // filenames
Links []string `json:"links"` // filenames
}

// Custom is a generic structure that contains in-toto Metadata
type Custom struct {
InToto Metadata `json:"in-toto"`
InToto Metadata `json:"intoto"`
}

// PublicKeys is a map from the GUN-qualified filename
Expand Down
6 changes: 0 additions & 6 deletions pkg/tuf/common.go
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
// Most of the helper functions are adapted from github.com/theupdateframework/notary
//
// Figure out the proper way of making sure we are respecting the licensing from Notary
// While we are also vendoring Notary directly (see LICENSE in vendor/github.com/theupdateframework/notary/LICENSE),
// copying unexported functions could fall under different licensing, so we need to make sure.

package tuf

import (
Expand Down
1 change: 0 additions & 1 deletion pkg/tuf/common_test.go

This file was deleted.

2 changes: 1 addition & 1 deletion pkg/tuf/sign.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ func reuseKeys(repo client.Repository, rootKey string) error {
}

default:
return fmt.Errorf("cannot list targets: %v", err)
return fmt.Errorf("cannot list targets while reusing keys: %v", err)
}
}
return nil
Expand Down

0 comments on commit f786da0

Please sign in to comment.