Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push to registry-then-notary instead of other way around #46

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

trishankatdatadog
Copy link
Member

We first push to the Registry, and then Notary. This is so that if we modify the bundle locally, we will not invalidate its signature by first pushing to Notary, and then the Registry.

Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please sign-off the commit?

Otherwise, LGTM, thanks!

Signed-off-by: Trishank K Kuppusamy <trishank.kuppusamy@datadoghq.com>
@trishankatdatadog trishankatdatadog force-pushed the trishankatdatadog/registry-then-notary branch from 36c9b8b to 2889e44 Compare February 6, 2020 22:54
@radu-matei radu-matei merged commit 7d8fd32 into master Feb 6, 2020
@radu-matei radu-matei deleted the trishankatdatadog/registry-then-notary branch February 6, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants