Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go version to 1.13 #56

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Update Go version to 1.13 #56

merged 2 commits into from
Feb 19, 2020

Conversation

radu-matei
Copy link
Member

@radu-matei radu-matei commented Feb 14, 2020

closes #58

@radu-matei radu-matei changed the title Mods 113 Update Go version to 1.13 Feb 14, 2020
@radu-matei
Copy link
Member Author

Updated, and also removed the unused dep files.

Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but what's this message from GitHub? 👀

image

@radu-matei
Copy link
Member Author

@trishankatdatadog - that is related to #58, I think we might have an incompatible linter version.

GitHub is only reporting what it sees from the action logs.

Update GH action Go version to 1.13

Update GH actions Go version

Remove unused dep files and environment variable from Actions

Signed-off-by: Radu M <root@radu.sh>
Signed-off-by: Radu M <root@radu.sh>
@radu-matei
Copy link
Member Author

Fixed the linter errors by updating the golangci-lint version.

@radu-matei radu-matei merged commit 19e3f12 into cnabio:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential linter errors caused by incompatible verions
3 participants