-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PUE to SCI dashboard #76
Conversation
…in dashboard Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Hi @nikimanoledaki @rossf7 this is ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raymundovr Awesome, thanks for adding
Left some minor comments but then looks good. We'll most likely merge this from the 🚆 on Monday :D
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com> Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com> Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com> Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com> Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com> Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
010123d
to
3a6266c
Compare
@rossf7 Thank you for checking this, all resolved. Sorry for the multiple commits, was trying to resolve using the Github tools but forgot about the sign-off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you for adding the PUE, @raymundovr! Really good call 😄
My only feedback is that I would make PUE part of E
as this is also the guidance from the SCI documentation which you linked to:
If the boundary includes on-premise and/or cloud data center operations, E should take into account the efficiency of the data center, including cooling and other energy consumption necessary to operate a data center. The data center's energy efficiency is usually available as a PUE (Power Usage Effectiveness) value.
Left a couple of comments to address this. I'm open to discussing this further, let me know what you think!
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Hi @nikimanoledaki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raymundovr thank you for your patience and apologies for the delay! LGTM 🎉 💚
What type of PR is this?
kind/documentation
kind/enhancement
What this PR does / why we need it:
GSF SCI specification states that cloud computing operations should include the efficiency of the data center where the software runs in the calculation, see here. This efficiency is measured by the Power Usage Effectiveness (PUE).
This PR adds the PUE to the calculation shown in the dashboard and makes some additions to the documentation to include information about it.
Which issue(s) this PR fixes:
None