Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PUE to SCI dashboard #76

Merged
merged 14 commits into from
Apr 4, 2024

Conversation

raymundovr
Copy link
Contributor

@raymundovr raymundovr commented Mar 13, 2024

What type of PR is this?

kind/documentation
kind/enhancement

What this PR does / why we need it:

GSF SCI specification states that cloud computing operations should include the efficiency of the data center where the software runs in the calculation, see here. This efficiency is measured by the Power Usage Effectiveness (PUE).

This PR adds the PUE to the calculation shown in the dashboard and makes some additions to the documentation to include information about it.

Which issue(s) this PR fixes:

None

…in dashboard

Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
@raymundovr raymundovr changed the title Feat/sci dashboard Add PUE to SCI dashboard Mar 13, 2024
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
@raymundovr
Copy link
Contributor Author

Hi @nikimanoledaki @rossf7 this is ready for review :)

Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raymundovr Awesome, thanks for adding

Left some minor comments but then looks good. We'll most likely merge this from the 🚆 on Monday :D

clusters/base/falco-sci.yaml Outdated Show resolved Hide resolved
clusters/base/falco-sci.yaml Outdated Show resolved Hide resolved
clusters/base/falco-sci.yaml Outdated Show resolved Hide resolved
docs/measurement/sci.md Outdated Show resolved Hide resolved
docs/measurement/sci.md Outdated Show resolved Hide resolved
docs/measurement/sci.md Outdated Show resolved Hide resolved
raymundovr and others added 6 commits March 16, 2024 19:28
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
@raymundovr
Copy link
Contributor Author

@rossf7 Thank you for checking this, all resolved. Sorry for the multiple commits, was trying to resolve using the Github tools but forgot about the sign-off.

Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for adding the PUE, @raymundovr! Really good call 😄

My only feedback is that I would make PUE part of E as this is also the guidance from the SCI documentation which you linked to:

If the boundary includes on-premise and/or cloud data center operations, E should take into account the efficiency of the data center, including cooling and other energy consumption necessary to operate a data center. The data center's energy efficiency is usually available as a PUE (Power Usage Effectiveness) value.

Left a couple of comments to address this. I'm open to discussing this further, let me know what you think!

clusters/base/falco-sci.yaml Outdated Show resolved Hide resolved
docs/measurement/sci.md Outdated Show resolved Hide resolved
docs/measurement/sci.md Outdated Show resolved Hide resolved
raymundovr and others added 4 commits March 18, 2024 20:31
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
Signed-off-by: Raymundo Vásquez Ruiz <raymundo.vr@protonmail.com>
@raymundovr
Copy link
Contributor Author

Hi @nikimanoledaki
Noticed that in the docs the PUE was already removed from the equation. To align it, I went with the proposed change for the falco-sci.yaml as well.
This resolves with your suggested changes.

Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raymundovr thank you for your patience and apologies for the delay! LGTM 🎉 💚

@nikimanoledaki nikimanoledaki merged commit 36b7907 into cncf-tags:main Apr 4, 2024
1 check passed
@nikimanoledaki nikimanoledaki deleted the feat/sci-dashboard branch April 4, 2024 08:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants