Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intake process and prioritization #296

Merged
merged 14 commits into from
Jan 7, 2020
Merged

intake process and prioritization #296

merged 14 commits into from
Jan 7, 2020

Conversation

ultrasaurus
Copy link
Member

Moving doc to pull request. Reviewed by TOC Liaissons @lizrice and @jbeda and co-chairs

Additional feedback welcome!

Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments to adjust language and formatting

assessments/intake-process.md Outdated Show resolved Hide resolved
assessments/intake-process.md Outdated Show resolved Hide resolved
assessments/intake-process.md Outdated Show resolved Hide resolved
@lumjjb
Copy link
Contributor

lumjjb commented Nov 18, 2019

To address #281

assessments/intake-process.md Outdated Show resolved Hide resolved
assessments/intake-process.md Outdated Show resolved Hide resolved
assessments/intake-process.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumjjb
Copy link
Contributor

lumjjb commented Dec 4, 2019

Is the intake priority queue going to live somewhere in the repo as well? Or is it something that is going to be managed through an issue (or github project)?

@ultrasaurus
Copy link
Member Author

Currently the "priority queue" is a matrix and there's some discussing about refactoring that #309 and #206 -- I guess I could link to the matrix and we can just remember to fix the link if it gets renamed.

Will wait for @JustinCappos review of this PR and see what he thinks

assessments/intake-process.md Outdated Show resolved Hide resolved
assessments/intake-process.md Outdated Show resolved Hide resolved
assessments/intake-process.md Outdated Show resolved Hide resolved
assessments/intake-process.md Show resolved Hide resolved
assessments/intake-process.md Outdated Show resolved Hide resolved
assessments/intake-process.md Outdated Show resolved Hide resolved
assessments/README.md Show resolved Hide resolved
assessments/README.md Outdated Show resolved Hide resolved
assessments/README.md Outdated Show resolved Hide resolved
@ultrasaurus ultrasaurus self-assigned this Dec 18, 2019
@ultrasaurus
Copy link
Member Author

There are a couple of comments that I still need to review, but most of the feedback has been addressed. Would welcome any new set of eyes to take a look!

@dshaw dshaw self-requested a review January 7, 2020 03:39
@ultrasaurus
Copy link
Member Author

I think this is ready to go!

Copy link
Contributor

@dshaw dshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dshaw dshaw requested a review from pragashj January 7, 2020 03:54
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but requires broken link fix.

assessments/intake-process.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ultrasaurus Thoughts? I'm fine merging, but would prefer to make edits like I describe.

* The project has identified a project lead and has a written self-assessment

# Intake priorities

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note, this is meant to be informational, not a set of rules that must be followed. These guidelines are meant to give some
rationale for our thought process, but these are not binding rules.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added text to address this to clarify how this would work as guidance -- a lightweight process for us to manage exceptions, keeping TOC in the loop


# Updates and renewal

The Security Assessment team will aim to review assessed projects annually,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This somewhat conflicts with 2 above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to "aim to" in response to your earlier comment. does that help?

addressing feedback from Justin Cappos
added a description of priorities as guidance, where we'll
communicate what we're doing on a regular heartbeat and
facilitator and named chair coordinate
chatted with JustinCappos via Slack who agreed this can be
addressed as separate PR
@JustinCappos JustinCappos merged commit d6303cb into master Jan 7, 2020
@ultrasaurus ultrasaurus mentioned this pull request Mar 16, 2021
@lumjjb lumjjb deleted the intake-process branch February 9, 2022 14:59
Michael-Susu12138 pushed a commit to Michael-Susu12138/tag-security that referenced this pull request Dec 12, 2023
intake process and prioritization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants