-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Native Security Whitepaper submitted #452
Cloud Native Security Whitepaper submitted #452
Conversation
I haven't looked through content, since I know you are still working on it. Just wanted to make a couple of requests:
Thanks so much for your work on the conversion! We should pull in White Paper authors when it is ready for review. |
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
ffa9858
to
f6e5933
Compare
@idvoretskyi a quick skim - everything looks in place. I made some alterations to the initial content in preparation for the upcoming post. |
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
@TheFoxAtWork thanks! |
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
…kyi/sig-security into idvoretskyi-security-whitepaper
**Work-Group:** SIG-Security **Short self link to working doc:** https://tinyurl.com/CNCF-CNSWP | **Status** : WIP | In Review | **Approved** | Obsolete | ||
|
||
**Created** : 2020-FEB-01 **Reviewed** : 2020-OCT-27 **Published** : 2020-NOV-18 **Release Version:** 1.0 **Approvers** : [x] @lizrice [x] @justincormack | | ||
| **Contributors:** [aradhna.chetal@gmail.com](mailto:aradhna.chetal@gmail.com), [themoxiefoxatwork@gmail.com](mailto:themoxiefoxatwork@gmail.com), [jj@tetrate.io](mailto:jj@tetrate.io), gadi@alcide.io @lumjjb, @trishankatdatadog, [@vvenkatara@paloaltonetworks.com](mailto:vvenkatara@paloaltonetworks.com), @pushkarj-v, @whaber, @sublimino, @rowan-baker, [chase.pettet@gmail.com](mailto:chase.pettet@gmail.com), [harsingh@us.ibm.com](mailto:harsingh@us.ibm.com), jeff.lombardo@gmail.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idvoretskyi : Had a recent change in my Github ID/username and the one here does not exist. Can you please replace @pushkarj-v
with @pushkarj
? Thanks and sorry for the bother.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add links to the github IDs as well?
@idvoretskyi added a few comments, mostly nits. Thank you so much, for your excellent work :) |
@PushkarJ thanks a lot, will address them! |
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple suggested changes to remove implementation and vendor specific details, and content rewording, and several other formatting and clarification additions.
Co-authored-by: Brandon Lum <lumjjb@gmail.com>
@TheFoxAtWork ping for the final review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lumjjb @pragashj @ultrasaurus @JustinCappos need a second approval on this to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
micro stack issues
* Cloud Native Security Whitepaper submitted Signed-off-by: Ihor Dvoretskyi <ihor@linux.com> * Cloud Native Security Whitepaper submitted Signed-off-by: Ihor Dvoretskyi <ihor@linux.com> * Update security-whitepaper/cloud_native_security_whitepaper.md Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> * Update security-whitepaper/cloud_native_security_whitepaper.md Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> * MD File renamed Signed-off-by: Ihor Dvoretskyi <ihor@linux.com> * Formatting fixes & comments addressed Signed-off-by: Ihor Dvoretskyi <ihor@linux.com> * Apply suggestions from code review Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Brandon Lum <lumjjb@gmail.com> * Update security-whitepaper/cloud-native-security-whitepaper.md Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com> Co-authored-by: Brandon Lum <lumjjb@gmail.com>
Signed-off-by: Ihor Dvoretskyi ihor@linux.com