Finish HttpAttributesCelMatchInput - address skip_if_error

cncf · May 12, 2022 · 15dfe65 · 15dfe65
1 parent b1297be
commit 15dfe65
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/xds/type/matcher/v3/http_inputs.proto b/xds/type/matcher/v3/http_inputs.proto
@@ -38,8 +38,13 @@ option (xds.annotations.v3.file_status).work_in_progress = true;
 //
 // Refer to :ref:`Unified Matcher API <envoy_v3_api_msg_.xds.type.matcher.v3.Matcher>` documentation
 // for usage details.
-// [#comment:TODO(sergiitk): Add extension category.]
-// // [#not-implemented-hide:]
+//
+// .. attention::
+//
+//   In case CEL expression raises an error, the result of the evaluation is interpreted
+//   short-circuited "no match". Associated Matcher is not evaluated.
+//
+// [#extension: envoy.matching.inputs.http_attributes]
 message HttpAttributesCelMatchInput {
   // CEL expression to evaluate.
   type.v3.CelExpression expr = 1 [(validate.rules).message = {required: true}];

diff --git a/xds/type/v3/cel.proto b/xds/type/v3/cel.proto
@@ -25,7 +25,6 @@ message CelExpression {
     option (validate.required) = true;
 
     // Parsed expression in abstract syntax tree (AST) form.
-    // [#comment:TODO(sergiitk): Or Expr?]
     google.api.expr.v1alpha1.ParsedExpr parsed_expr = 1;
 
     // Parsed expression in abstract syntax tree (AST) form that has been successfully type checked.