Configurable keyboard pendant #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So,... the original implementation of cncjs-pendant-keyboard had exactly one keyboard and keyboard layout baked in to the code. Instead of cloning and hacking in the changes relevant to me, I decided to open it up somewhat and make it configurable through the .cncrc file.
And since configuring a USB HID keyboard and the keymapping is not straightforward, I decided to add in a configuration tool.
It's not the best or most finished code I've ever written, but this is as far as my energy could bring me, at the moment. I'm willing to do some more updates later on (especially if some requests come in).
The readme.md and package.json reference my fork of cncjs-pendant-keyboard, I suppose you want to change those URLs before accepting the pull request.
Let me know if you have any more questions or if I have to clean something up.