Dev 4.0.0 (#189)

* Refactoring for i-Code 4 (#164)

* start of refactoring to remove rcp from command line and core analyzer

* Second step

* All languages are built

* Fix export string problem and add new supported features

* All rules integrated.

* Finalized command line version.
- three languages supported
- plugin system available
- packaging on build available
- directory as argument available
- deletion of parallel analysis

* Add version information to command line

* Add parametrized unit tests

* Update .travis.yml

* fix encoding issues, prepare new packagings and clean up repository

* update pom to fix issues and deploy library

* fix shell-rules pom

* minor changes

* Refactoring

* Add functional icode-ide working with a icode-libray jar put in icode-library-plugin // Refactor code // Add some license headers

* RCP versions are reintegrated as icode-ide

* Update CI (deploy and jdk) + start new readme

* Update .travis.yml

* Change to icode 4 + README

* Change README

* Update README.md

* Fix compatibility with JRE>8 && update CI

* deploy only on build on jdk11

* Remove build on jdk8

* [#166] Fix #166 by adding heredoc support to metrics

* [#166] Fix #166 by adding heredoc support to metrics

* [#166] Fix #166 by adding here string support to shell metrics

* [#145] Add coverage with jacoco

* [#142] Add i-Code version in xml reports

* Fix #168: support of for with double parentheses

* Fix #158 Remove 'read' from active wait functions

* #187 Complete contributing requirements

* #187 Fix layout

* #187 fix plan

* #187 Add issue templates

* #187 add a template with checklist for PR

* Delete PULL_REQUEST_TEMPLATE.md

Move template into .github folder

* Delete ISSUE_TEMPLATE.md

Move template into .github

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* #165 add execution rights for icode-app scripts

* #158 fix tests

* #165 Update README to match the new structure

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update README.md

* Add coverage for SonarQube

* Use Junit Jupiter 5 to run tests

* Convert test to JUnit 5 tests with generalisation of chercker tests

* add sonar-project.properties

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,32 @@
+---
+name: Bug report
+about: Create a report to help us improve i-Code
+title: ''
+labels: bug, to analyse
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots & log**
+If applicable, add screenshots to help explain your problem. Then, append i-Code log and **do not forget to obfuscate them**.
+
+**User environment (please complete the following information):**
+ - OS: [e.g. Windows 10]
+ - Java version: [e.g. 1.8]
+ - i-Code version: [e.g. 3.1.0]
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/false-positive-report.md

@@ -0,0 +1,28 @@
+---
+name: False positive report
+about: Create a report about i-Code false positive alerts
+title: ''
+labels: to analyse, false positive
+assignees: ''
+
+---
+
+**Describe the false positive detection**
+A clear and concise description of what the false positive is.
+
+**Simple snippet of code raising false positive**
+
+```
+my code raising false positive
+```
+
+**Screenshots & log**
+If applicable, add screenshots to help explain your problem. Then, append i-Code log and **do not forget to obfuscate them**.
+
+**User environment (please complete the following information):**
+ - OS: [e.g. Windows 10]
+ - Java version: [e.g. 1.8]
+ - i-Code version: [e.g. 3.1.0]
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for improving i-Code
+title: ''
+labels: enhancement, to analyse
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/ISSUE_TEMPLATE/question.md

@@ -0,0 +1,24 @@
+---
+name: Question
+about: Ask a question about i-Code usage
+title: ''
+labels: question
+assignees: ''
+
+---
+
+> **Before posting a new question, please read the documentation](https://github.com/lequal/i-CodeCNES/wiki) and check [existing issues](https://github.com/lequal/i-CodeCNES/issues)**
+
+**Describe what you need to know**
+A clear and concise description of what your question is.
+
+**Screenshots & log**
+If applicable, add screenshots to help explain your problem. Then, append i-Code log and **do not forget to obfuscate them**.
+
+**User environment (please complete the following information):**
+ - OS: [e.g. Windows 10]
+ - Java version: [e.g. 1.8]
+ - i-Code version: [e.g. 3.1.0]
+
+**Additional context**
+Add any other context about the problem here.

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,35 @@
+## Proposed changes
+
+> Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
+
+## Types of changes
+
+What types of changes does your code introduce to i-Code?
+> _Put an `x` in the boxes that apply_
+
+- [ ] Bugfix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+- [ ] Documentation Update (if none of the other choices apply)
+
+## Issues closed by changes
+
+> _List here all issues closed by your changes. Use a list of items like `- [x] Close #0`_
+
+- [x] Close #0
+
+## Checklist
+
+> _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
+
+- [ ] I have read the [CONTRIBUTING](https://github.com/lequal/i-CodeCNES/blob/master/CONTRIBUTING.md) doc
+- [ ] I agree with the [CODE OF CONDUCT](https://github.com/lequal/i-CodeCNES/blob/master/CONTRIBUTING.md)
+- [ ] Lint and unit tests pass locally with my changes
+- [ ] SonarCloud and Travis CI tests pass with my changes
+- [ ] I have added tests that prove my fix is effective or that my feature works
+- [ ] I have added necessary documentation (if appropriate)
+- [ ] Any dependent changes have been merged and published in downstream modules
+
+## Further comments
+
+> If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

.gitignore

@@ -4,9 +4,25 @@
 bin/
 target/
 */target/**
+*-pom.xml
+*/*-pom.xml
 
 # Ignore code generation directories 
 */src-gen/fr/
 
 #Ignore checkstyle configuration
 *.checkstyle
+
+# Ignore IDE metadata
+.idea
+.iml
+*.iml
+*/*.iml
+.project
+*/.project
+.classpath
+*/.classpath
+.settings
+
+# Ignore SonarQube metadata
+.scannerwork

.travis.yml

@@ -1,11 +1,40 @@
-language: java
-jdk:
-  - oraclejdk8
-install: true
-script : 
-  - mvn install -DskipTests
-  - mvn verify
-sudo: false
-addons:
-  sonarcloud:
-    organization: "lequal"
+language: java
+install: true
+
+os:
+- linux
+
+jdk:
+- openjdk11
+
+addons:
+  sonarcloud:
+    organization: "lequal"
+    token:
+      secure: "XrTPbT5js+N1quKghtNNwb+F911kkREvm1ucDUb6vBwfGY5n/du9Mas5R632HuV/s8pJcJGi66NwzxhjaZGzvsNT+WhhRzeOTunpPSXzrW1wkN3cYyiURqN7p7c+YhmGVtymgiDmWh9/hamxsWp7PsmnGsAHe8U/omhV/7riU73/AwPahdeAaLdRegUrEvL9814q88d7g6A9gPFssPq9p+NLGP1J7zyNEWfHz59i0GRKFtmBTvqhONvFsostTZ1F+MJRv+Z5YIVCzkiOr99TRYrIQCwBmTXNWp/pZyKTV2xahhdY1UFY7Mtk4IUzrGhTBwaqsazMwF5EI2qdL0oKTabNEQoLtJoIA+vVLS9vONf3/zijcGnMQZvtI0M7HaXuAdIdXXpj/OZdPSrqZy1rVy7RQWoTyK4Wv8jwls3Ocrbpojo/uaSJk4t/iCyToURgQzTPPbeSkX52fFt0ylOnCEQVm8OSjcnx3WeM5jm8moaPXGsJjSvsUjGbyVWwTiqe/oAY1vJDY6TT11+v4mCmLyv21AQg16euMhuSQMKaml/F8Gt/th0Yr1HCXn6Vcw7fwU9IX2sbFrTlip7e4XQ/ohZXuM37IjG/9CrqFU2AI55HneQXERH7qkMTEiZOTYg7vbHZkzzBLTBlPEwtmlnYSObiOq2BFXxzY1wgP3jGTVQ="
+
+script:
+  - mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent package org.jacoco:jacoco-maven-plugin:report
+  - if [ "$JAVA_HOME" = "/usr/lib/jvm/java-1.8.0-openjdk-amd64" ]; then sonar-scanner; fi
+
+cache:
+  directories:
+  - '$HOME/.m2/repository'
+  - '$HOME/.sonar/cache'
+
+notifications:
+  email: false
+
+deploy:
+  provider: releases
+  api_key: "$GITHUB_TOKEN"
+  file_glob: true
+  file:
+  - "icode-app/target/icode-*.zip"
+  - "icode-ide/fr.cnes.icode.repository/target/products/icode-ide.product-*.zip"
+  - "icode-ide/fr.cnes.icode.repository/target/fr.cnes.icode.repository-*.zip"
+  skip_cleanup: true
+  name: "i-Code CNES"
+  draft: true
+  on:
+    tags: true

CONTRIBUTING.md

@@ -3,13 +3,12 @@ First off, thanks for taking the time to contribute!
 The following is a set of guidelines for contributing to i-Code Cnes, which are hosted in the [Lequal Organization](https://github.com/lequal) on GitHub. These are mostly guidelines, not rules. Use your best judgment, and feel free to propose changes to this document in a pull request.
 
 #### Table Of Contents
-[Code of Conduct](#code-of-conduct)
-[How Can I Contribute?](#how-can-i-contribute)  
-* [Reporting Bugs](#reporting-bugs)  
-* [Suggesting Enhancements](#suggesting-enhancements)  
-* [Pull Requests](#pull-requests)
-
-[Git Commit Messages](#git-commit-messages)
++ [Code of Conduct](#code-of-conduct)
++ [How Can I Contribute?](#how-can-i-contribute)  
+  * [Reporting Bugs](#reporting-bugs)  
+  * [Suggesting Enhancements](#suggesting-enhancements)  
+  * [Pull Requests](#pull-requests)
+  * [Git Commit Messages](#git-commit-messages)
 
 ## Code of Conduct
 This project and everyone participating in it is governed by the [Lequal Code of Conduct](CODE_OF_CONDUCT.md). By participating, you are expected to uphold this code. Please report unacceptable behavior to [L-lequal@cnes.fr](mailto:L-lequal@cnes.fr).
@@ -32,7 +31,9 @@ Explain the problem and include additional details to help maintainers reproduce
 * **If you're reporting that the plugin crashed**, include a crash report with a stack trace from the operating system.
 
 Provide more context by answering these questions:
-* **Did the problem start happening recently** (e.g. after updating to a new version of the plugin or SonarQube) or was this always a problem?* If the problem started happening recently, **can you reproduce the problem in an older version?** What's the most recent version in which the problem doesn't happen? You can download older versions from [the releases page](https://github.com/lequal/i-CodeCNES/releases).* **Can you reliably reproduce the issue?** If not, provide details about how often the problem happens and under which conditions it normally happens.
+* **Did the problem start happening recently** (e.g. after updating to a new version of the plugin or SonarQube) or was this always a problem?
+* If the problem started happening recently, **can you reproduce the problem in an older version?** What's the most recent version in which the problem doesn't happen? You can download older versions from [the releases page](https://github.com/lequal/i-CodeCNES/releases).
+* **Can you reliably reproduce the issue?** If not, provide details about how often the problem happens and under which conditions it normally happens.
 
 Include details about your configuration and environment:
 * **Which SonarQube version are you using?** You can get the exact version at the bottom of your SonarQube instance.
@@ -52,12 +53,27 @@ Enhancement suggestions are tracked as [GitHub issues](https://guides.github.com
 * **Specify the SonarQube version you're using.** The SonarQube version is mentionned at the bottom of the web page.
 
 ### Pull Requests
-* Fill in [the required template](PULL_REQUEST_TEMPLATE.md)
-* Do not include issue numbers in the PR title* Include screenshots and animated GIFs in your pull request whenever possible.
-* Follow the Java styleguides.
+* Fill in [the required template](.github/PULL_REQUEST_TEMPLATE.md)
+* Do not include issue numbers in the PR title
+* Include screenshots and animated GIFs in your pull request whenever possible
+* Follow the Java styleguides and fix all new SonarCloud issues
+* Test your code before opening the PR
+* Set the current `dev-*` branch as the target branch for your PR
 
-## Git Commit Messages
+### Git Commit Messages
+* Start with the issue you are handling ("#187 ...")
 * Use the present tense ("Add feature" not "Added feature")
 * Use the imperative mood ("Move cursor to..." not "Moves cursor to...")
-* Limit the first line to 72 characters or less* Reference issues and pull requests liberally after the first line
+* Limit the first line to 72 characters or less
+* Reference issues and pull requests liberally after the first line
 * When only changing documentation, include `[ci skip]` in the commit description
+
+## Management of contributions
+
+All contributions are welcome. They are made via a *pull request* on the branch `dev` which is the branch of the next version.
+
+* pull request with **major** changes must be approved by at least one maintainer of each team and the LEQUAL.
+
+* pull requests with **minor** changes must be approved by at least one organization's member.
+
+All maintainers have the ability to merge *pull requests* on the `dev` branch. If several maintainers belong to the same team, their validation only counts for one organization.