Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality #77

Closed
4 tasks done
WaldoFR opened this issue Aug 3, 2017 · 0 comments
Closed
4 tasks done

Code quality #77

WaldoFR opened this issue Aug 3, 2017 · 0 comments
Assignees
@WaldoFR
Milestone
Version 3.0.0

Comments

@WaldoFR
Copy link

WaldoFR commented Aug 3, 2017 •
edited
Loading

Some files still contains :

  • TODO elements;
  • Checkstyles, PMD or findbugs violations;
  • Java warnings;
  • Lex warnings.

Code should be cleaned.
@WaldoFR WaldoFR self-assigned this Aug 3, 2017
@WaldoFR WaldoFR added this to the Version 3.0 milestone Aug 3, 2017
WaldoFR pushed a commit to WaldoFR/i-CodeCNES that referenced this issue Aug 4, 2017
Update cnescatlab#77 Cleaning code.
71d04dc
@WaldoFR WaldoFR mentioned this issue Aug 4, 2017
Merged
WaldoFR pushed a commit to WaldoFR/i-CodeCNES that referenced this issue Aug 21, 2017
Fix cnescatlab#51 (+Update cnescatlab#77) compareFiles method correction
3a36a9f
dupuisa pushed a commit that referenced this issue Aug 29, 2017
#77 Manage lex generation warnings and java warnings
880049f
WaldoFR pushed a commit to WaldoFR/i-CodeCNES that referenced this issue Sep 4, 2017
Fix cnescatlab#50 & Update cnescatlab#77
fa3c7e2 
- Every exceptions thrown by checkers are sending more informative
messages

- Code was improved as defined in cnescatlab#77 with a logger & part of PMD &
checkstyle issues were solved

About the logger, a new class UILogger was made. It runs
org.eclipse.logger logger so all the logs are written directly to /*.log
file of ./metadata of workspace and /configuration of eclipse folder.
To precise the level of log a parameter must be indicated on the launch,
as defined in this page :
(https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fruntime-options.html
). So the following argument can be used to define level of the logger
-Declipse.log.level=<level> where level can be INFO, WARNING, or ERROR.

An important change was made on ConfigurationPagePreferences that was
using CheckerTableViewer and MetricsTableViewer in a composite
Container. These class are now extending Composite that contains a
search SWT.label, a SWT.Text (for the search input) and a TableViewer
with Checkers and parameters relatives to them. Old composite containing
these class was replaced by the new CheckerComposite and
MetricsComposite.
WaldoFR pushed a commit to WaldoFR/i-CodeCNES that referenced this issue Sep 7, 2017
Update cnescatlab#88 & Fix cnescatlab#77 Using ICodeLogger to log event.
d17dc76
@WaldoFR WaldoFR mentioned this issue Sep 10, 2017
Merged
@WaldoFR WaldoFR closed this as completed Sep 13, 2017
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
Update cnescatlab#77 Cleaning code.
e021363
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
Fix cnescatlab#51 (+Update cnescatlab#77) compareFiles method correction
1d11ff8
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@dupuisa
cnescatlab#77 Manage lex generation warnings and java warnings
9039e6e
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
Fix cnescatlab#50 & Update cnescatlab#77
9af8af5 
- Every exceptions thrown by checkers are sending more informative
messages

- Code was improved as defined in cnescatlab#77 with a logger & part of PMD &
checkstyle issues were solved

About the logger, a new class UILogger was made. It runs
org.eclipse.logger logger so all the logs are written directly to /*.log
file of ./metadata of workspace and /configuration of eclipse folder.
To precise the level of log a parameter must be indicated on the launch,
as defined in this page :
(https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fruntime-options.html
). So the following argument can be used to define level of the logger
-Declipse.log.level=<level> where level can be INFO, WARNING, or ERROR.

An important change was made on ConfigurationPagePreferences that was
using CheckerTableViewer and MetricsTableViewer in a composite
Container. These class are now extending Composite that contains a
search SWT.label, a SWT.Text (for the search input) and a TableViewer
with Checkers and parameters relatives to them. Old composite containing
these class was replaced by the new CheckerComposite and
MetricsComposite.
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
Update cnescatlab#88 & Fix cnescatlab#77 Using ICodeLogger to log event.
f98d79c
begarco pushed a commit that referenced this issue Feb 2, 2020
Update #77 Cleaning code.
454f578
begarco pushed a commit that referenced this issue Feb 2, 2020
Fix #51 (+Update #77) compareFiles method correction
ad8e4d9
begarco pushed a commit that referenced this issue Feb 2, 2020
@dupuisa
#77 Manage lex generation warnings and java warnings
c421d16
begarco pushed a commit that referenced this issue Feb 2, 2020
Fix #50 & Update #77
1d65d27 
- Every exceptions thrown by checkers are sending more informative
messages

- Code was improved as defined in #77 with a logger & part of PMD &
checkstyle issues were solved

About the logger, a new class UILogger was made. It runs
org.eclipse.logger logger so all the logs are written directly to /*.log
file of ./metadata of workspace and /configuration of eclipse folder.
To precise the level of log a parameter must be indicated on the launch,
as defined in this page :
(https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fruntime-options.html
). So the following argument can be used to define level of the logger
-Declipse.log.level=<level> where level can be INFO, WARNING, or ERROR.

An important change was made on ConfigurationPagePreferences that was
using CheckerTableViewer and MetricsTableViewer in a composite
Container. These class are now extending Composite that contains a
search SWT.label, a SWT.Text (for the search input) and a TableViewer
with Checkers and parameters relatives to them. Old composite containing
these class was replaced by the new CheckerComposite and
MetricsComposite.
begarco pushed a commit that referenced this issue Feb 2, 2020
Update #88 & Fix #77 Using ICodeLogger to log event.
76d86f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WaldoFR WaldoFR

Labels
None yet
Projects
None yet
Milestone
Version 3.0.0
Development

No branches or pull requests
1 participant
@WaldoFR