Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove shell #237

Merged
merged 23 commits into from
Jun 20, 2024
Merged

remove shell #237

merged 23 commits into from
Jun 20, 2024

Conversation

louisjdmartin
Copy link
Member

Proposed changes

As we have deprecated Shell and did not maintain shell rules anymore, shell is removed from I-Code.
To analyze shell, please use shellcheck or older versions of I-Code

Types of changes

What types of changes does your code introduce to i-Code?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • SonarCloud and GitHub Actions tests pass with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@louisjdmartin louisjdmartin changed the base branch from master to develop June 20, 2024 12:42
@louisjdmartin louisjdmartin changed the base branch from develop to master June 20, 2024 12:45
@louisjdmartin louisjdmartin changed the base branch from master to develop June 20, 2024 12:45
@louisjdmartin louisjdmartin merged commit d5a1a85 into develop Jun 20, 2024
4 checks passed
@louisjdmartin louisjdmartin added this to the 5.0.0 milestone Jun 20, 2024
louisjdmartin added a commit that referenced this pull request Jun 20, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants