Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sonar-scanner import error when empty line #3

Conversation

aglensmith
Copy link

Proposed changes

This applies Turiok's PR sonar-scanner import error when empty line made to omegacen/pylint-sonarjson.

SonarScanner does not expect startColumn to be included in the report JSON for issues on empty lines because empty lines do not have columns. With this change, startColumn is omitted if the message column is not greater than 0.

More context here: https://sonarsource.atlassian.net/browse/SONAR-20958

Types of changes

What types of changes does your code introduce to this project?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

@tbutler-qontigo
Copy link

@louisjdmartin could this be applied and released? We had to stop using the plugin because Sonar won't fix the issue on their end and this is happening for us.
thanks

Copy link
Member

@louisjdmartin louisjdmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for approving this PR, but before, can you edit setup.py to upgrade version to 2.0.1 ?

@tbutler-qontigo
Copy link

Ok for approving this PR, but before, can you edit setup.py to upgrade version to 2.0.1 ?

@aglensmith Can you make this change since the PR is from your fork? Thanks

@aglensmith
Copy link
Author

aglensmith commented Sep 10, 2024

@tbutler-qontigo @louisjdmartin I've updated the version to 2.0.1 as requested

@louisjdmartin louisjdmartin self-requested a review September 30, 2024 12:22
@louisjdmartin louisjdmartin merged commit 66c4ef0 into cnescatlab:master Sep 30, 2024
@tbutler-qontigo
Copy link

@louisjdmartin Could you publish this version to pypi,org? It still only has 2.0.0 as the latest version.

@louisjdmartin
Copy link
Member

It's already published, we reused original repo name (the "-catlab" was before we get write permissions)

https://pypi.org/project/pylint-sonarjson/

I'm going to fix readme soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants