Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove package-lock.json #218

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Remove package-lock.json #218

merged 1 commit into from
Apr 13, 2021
+0 −8,668

Conversation

ErwanGauduchon
Copy link
Contributor

Proposed changes

Removed package-lock.json as yarn is used instead of npm.

Types of changes

What types of changes does your code introduce to this software?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

Checklist

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • SonarCloud and Travis CI tests pass with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sancretor Sancretor added this to the 4.0.0 milestone Apr 13, 2021
@Sancretor Sancretor merged commit c5d677a into dev Apr 13, 2021
@Sancretor Sancretor deleted the remove-npm branch April 13, 2021 07:42
@Sancretor Sancretor removed this from the 4.0.0 milestone May 10, 2021
@Sancretor Sancretor linked an issue Aug 27, 2021 that may be closed by this pull request
Remove package-lock.json #209
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sancretor Sancretor Sancretor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove package-lock.json
2 participants
@ErwanGauduchon @Sancretor