Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#345 Sonarqube new LTS 9.9 support #347

Closed
wants to merge 7 commits into from
Closed

Conversation

theljade
Copy link

Proposed changes

Update of all sonarqube dependencies to be compatible with de last sonarqube LTS 9.9.*
I also updated all dependencies to the last version (except poi-ooxml and slf4j which are breaking).
The last sonar-ws dependency is not anymore compatible with java 8, then I had to delete the java 8 continious integration test.

Types of changes

What types of changes does your code introduce to this software?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • SonarCloud and Travis CI tests pass with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@BraisVQ
Copy link

BraisVQ commented Feb 15, 2023

Hi @theljade I am not a member of this organization at all but I am also interested in the support for SonarQube 9.9.x LTS
For the tests should this line not be updated ?
(even if you cannot run the github actions until someone approve it for you...)

@theljade
Copy link
Author

theljade commented Feb 15, 2023

Hi @theljade I am not a member of this organization at all but I am also interested in the support for SonarQube 9.9.x LTS For the tests should this line not be updated ? (even if you cannot run the github actions until someone approve it for you...)

@braisvq1996 Yes i did :) https://github.com/theljade/sonar-cnes-report/blob/master/.github/workflows/java-continuous-integration.yml#L46
You are just looking on the bad repository

@BraisVQ
Copy link

BraisVQ commented Feb 15, 2023

You are right @theljade, my bad

@wizpresso-steve-cy-fan
Copy link

@louisjdmartin would you like to review?

@louisjdmartin
Copy link
Member

louisjdmartin commented Mar 28, 2023

@wizpresso-steve-cy-fan we are currently working on upgrading the CNES-Report to make it compatible with SonarQube 9.9LTS (in order to upgrade docker-cat to 9.9 also)

@diegorodriguez31 you may take a look at this PR, looks like job is already done :)

Thanks for your contribution !

@louisjdmartin louisjdmartin added this to the 4.2.0 milestone Mar 28, 2023
@louisjdmartin louisjdmartin added the enhancement New feature or request label Mar 28, 2023
@diegorodriguez31
Copy link
Contributor

@theljade Thank you for your contribution.
Have you tested it on a SonarQube LTS9 community edition container?
On my end, it's not working. The Cnes-report tab is not available.
I'm investigating.

@wizpresso-steve-cy-fan
Copy link

@diegorodriguez31 I did not test the plugin mode but it works externally with 9.9 Community

@Silicoman
Copy link

Hi,

i have compiled locally the project and i have deployed on SonarQube Enterprise Edition Version 9.9 (build 65466)
I have the cnesreport tab and export seem working good.

Thank for your contribution.

image

@diegorodriguez31
Copy link
Contributor

diegorodriguez31 commented Apr 24, 2023

Thank you for all your contribution. I closed the MR but a new one is opened with our changes.

@marob
Copy link

marob commented Apr 24, 2023

@diegorodriguez31 Which MR is the new one?

@diegorodriguez31
Copy link
Contributor

@diegorodriguez31 Which MR is the new one?

#350

Sorry I should have note it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants