Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonarcloud integration #375

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Fix Sonarcloud integration #375

merged 6 commits into from
Jan 12, 2024

Conversation

louisjdmartin
Copy link
Member

@louisjdmartin louisjdmartin commented Jan 5, 2024

Proposed changes

Fix sonarqube analysis in CI

Types of changes

What types of changes does your code introduce to this software?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • SonarCloud and Travis CI tests pass with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@louisjdmartin louisjdmartin force-pushed the fix-ci branch 5 times, most recently from 354025c to b803b30 Compare January 5, 2024 14:43
@louisjdmartin
Copy link
Member Author

Must be squashed on merge
@Topin2001 can you review it? (on friday :) )

@louisjdmartin louisjdmartin added bug Something isn't working java Pull requests that update Java code labels Jan 8, 2024
@louisjdmartin louisjdmartin added this to the 4.3.0 milestone Jan 8, 2024
@louisjdmartin louisjdmartin linked an issue Jan 8, 2024 that may be closed by this pull request
@louisjdmartin louisjdmartin changed the title Fix sonar project key Fix Sonarcloud integration Jan 8, 2024
Copy link
Contributor

@Topin2001 Topin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it mandatory to keep java 11 in the matrix ? Since we are only using 17 (if I'm correct)

pom.xml Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@louisjdmartin louisjdmartin merged commit dd5d9f1 into dev Jan 12, 2024
7 checks passed
@louisjdmartin louisjdmartin deleted the fix-ci branch January 12, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken CI
2 participants