Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure resovlable domain name is used #22

Merged
merged 1 commit into from
Jul 30, 2024
Merged

ensure resovlable domain name is used #22

merged 1 commit into from
Jul 30, 2024

Conversation

nabuskey
Copy link
Contributor

fixes: #14

@nabuskey
ensure resovlable domain name is used
8201e13 
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
nimakaviani
nimakaviani approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit efa49b7 into main Jul 30, 2024
2 checks passed
@nabuskey nabuskey deleted the resolvable-url branch July 30, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimakaviani nimakaviani nimakaviani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use internally and externally resolvable git url
2 participants
@nabuskey @nimakaviani