Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Dapr integration #26

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Initial Dapr integration #26

merged 8 commits into from
Aug 9, 2024

Conversation

salaboy
Copy link
Contributor

@salaboy salaboy commented Aug 2, 2024

Fixes #16
Hi community, I am just building a simple Dapr integration for CNOE Stacks.
I would love to build deeper examples with Backstage, but I didn't found out much more resources on that.
Can you please help me to review this first?

Copy link

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great some minor requests

README.md Outdated Show resolved Hide resolved
dapr-integration/README.md Outdated Show resolved Hide resolved
dapr-integration/README.md Outdated Show resolved Hide resolved
dapr-integration/README.md Outdated Show resolved Hide resolved
@salaboy
Copy link
Contributor Author

salaboy commented Aug 6, 2024

@salaboy @nabuskey I think I made all the requested changes.. I will work on a separate repo for some Dapr Backstage templates.. let me know if you want me to add something else to this PR, I would prefer to keep it simple

@salaboy
Copy link
Contributor Author

salaboy commented Aug 6, 2024

@nabuskey sorry about that.. now it is fixed

dapr-integration/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This readme is light. What do you expect people to do once you have it installed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabuskey added more information and links

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix DCO? I think it's good to go after DCO is fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

salaboy added 8 commits August 9, 2024 07:11
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
@nabuskey nabuskey merged commit 7801f73 into cnoe-io:main Aug 9, 2024
1 check passed
@nimakaviani
Copy link
Contributor

Thank you @salaboy this is very cool. Would be good to publish some Backstage templates to go with it for some sample usecase applications similar ot what we have here and I think you and @csantanapr should have a "How to use Dapr in Dev Platforms" session maybe?

@salaboy
Copy link
Contributor Author

salaboy commented Aug 9, 2024 via email

@nimakaviani
Copy link
Contributor

awesome sounds good!

@csantanapr
Copy link

awesome @salaboy

elamaran11 pushed a commit to elamaran11/stacks that referenced this pull request Feb 6, 2025
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: Elamaran Shanmugam <elamaran.shan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Dapr for unified APIs to connect to infrastructure and promote best cloud native practices
4 participants