Added motor and ipac modules #11
Conversation
There was a problem hiding this comment.
Thanks for working on this!
I skimmed through the configuration and found somethings I think that might no be needed. Having the simplest configuration helps us maintaining it later.
Something you might not be familiar with (as I wasn't in the beginning) is to document the decisions you made in the commit messages (there is no need to document what you did, though, since this is already in the commit itself). I see you added no description to your commit, however there are several things I wasn't sure why you configured the way you did.
I think it can be interesting to mention why you have added IPAC module in the commit message. It seems to be a module required only for motorHytec.
You should also edit your commit instead of adding new commits patching your changes. Let me know if you have any questions regarding this. You should also follow the commit title style we have been using:
- start with
ioc:,base:orci:based on the part of the repository you are changing - use imperative instead of past tense (e.g.
add) - end with a period (
.) (That's really an Érico stuff. Haha)
Consistency helps us finding what we want in the future.
There was a problem hiding this comment.
Commit message can (and should) be more descriptive. I'd expect something like:
base: add support for motor.
Similarly to areaDetector, a separate script has been used to configure motor
module and its submodules due to its different setup.
IOCs in the support module are not built, since we currently do not use any of
them exactly the same way as they are configured in the community repositories.
This prevents the image size from increasing with unused build artifacts.
IPAC module is built to support `motorHytec`. This way, all motor modules
provided by the motor (super)module are supported.
Similarly to areaDetector, a separate script has been used to configure motor module and its submodules due to its different setup. IOCs in the support module are not built, since we currently do not use any of them exactly the same way as they are configured in the community repositories. This prevents the image size from increasing with unused build artifacts. IPAC module is built to support 'motorHytec'. This way, all motor modules provided by the motor (super)module are supported.
There was a problem hiding this comment.
Pending @henriquesimoes 's final review, I'm okay with merging this.
Thanks for the great work!
There was a problem hiding this comment.
It's fine by me as well. Thanks for working on this, @guirodrigueslima.
No description provided.