Support to uTCA IOC #62
Conversation
There was a problem hiding this comment.
Please, follow the pattern for commit header we use, that is:
base: add iocStats module.
base: add ipmiComm module.
We use base: for commits affecting the base image and ioc: for commits affecting the IOC images. We can always git log the file and see the past messages touching it.
Moreover, for each commit, add a item in the CHANGES.md file under the Unreleased section following the current pattern.
gustavosr8
force-pushed
the
ioc-utca-support
branch
5 times, most recently
from
35ce1fb to
9a7e6ca
Compare
There was a problem hiding this comment.
We're almost there, I think.
Typo in the 9a7e6ca: s/The patches solves/The patch solves.
gustavosr8
force-pushed
the
ioc-utca-support
branch
from
9a7e6ca to
292a572
Compare
There was a problem hiding this comment.
Looks fine by me. Adding @ericonr as reviewer for a second look. You may wait for his review before resolving the following point I noticed only now.
| * base: add IPMIComm module. by @gustavosr8 in | ||
| https://github.com/cnpem/epics-in-docker/pull/62 |
There was a problem hiding this comment.
Nit: I'd rather have a single line in the change list, but that's not mandatory.
gustavosr8
force-pushed
the
ioc-utca-support
branch
from
292a572 to
adfb47e
Compare
gustavosr8
force-pushed
the
ioc-utca-support
branch
from
adfb47e to
33e9dca
Compare
gustavosr8
force-pushed
the
ioc-utca-support
branch
from
33e9dca to
02ca34f
Compare
There was a problem hiding this comment.
It looks good to me. Thanks for working on this.
Just to be sure. Have you tested this latest version with https://github.com/lnls-dig/ipmi-mgr-epics-ioc?
The patch solves an overflow bug and a problem when linking. Both can be found in pull requests in ipmiComm repo, and the patch can be removed when the PRs are accepted.
gustavosr8
force-pushed
the
ioc-utca-support
branch
from
02ca34f to
ca64c72
Compare
No description provided.