Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

fix: don't sync constructor package on exists mode #883

Merged
merged 1 commit into from
Apr 9, 2016

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Apr 9, 2016

closes #857

@fengmk2 fengmk2 added the bug label Apr 9, 2016
@fengmk2 fengmk2 added this to the 2.x milestone Apr 9, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @dead-horse to be a potential reviewer

@fengmk2
Copy link
Member Author

fengmk2 commented Apr 9, 2016

cc @glen-84

@codecov-io
Copy link

Current coverage is 88.18%

Merging #883 into master will increase coverage by +0.03% as of 2eb8d88

@@            master    #883   diff @@
======================================
  Files           85      85       
  Stmts         3250    3250       
  Branches       602     602       
  Methods          0       0       
======================================
+ Hit           2865    2866     +1
  Partial         17      17       
+ Missed         368     367     -1

Review entire Coverage Diff as of 2eb8d88


Uncovered Suggestions

  1. +0.28% via .../web/package/show.js#159...167
  2. +0.28% via ...ync_module_worker.js#432...440
  3. +0.22% via services/npm.js#126...132
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@fengmk2 fengmk2 merged commit e0213e1 into master Apr 9, 2016
@fengmk2 fengmk2 deleted the fix-missing-sync-constructor-package branch April 9, 2016 04:33
@fengmk2
Copy link
Member Author

fengmk2 commented Apr 9, 2016

2.9.4

@glen-84
Copy link

glen-84 commented Apr 9, 2016

Thank you so much! I will test this early next week.

@glen-84
Copy link

glen-84 commented Apr 11, 2016

Verified fixed. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syncs package named "constructor" on new installation
5 participants